Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a Devfile dependency for commands #7063

Merged
merged 4 commits into from
Sep 4, 2023
Merged

Add a Devfile dependency for commands #7063

merged 4 commits into from
Sep 4, 2023

Conversation

feloy
Copy link
Contributor

@feloy feloy commented Sep 1, 2023 •
edited
Loading

What type of PR is this:

/kind bug

What does this PR do / why we need it:

This PR makes the following commands not dependent of a devfile.yaml present in the directory:

  • odo registry
  • odo init
  • odo analyze
  • odo list services
  • odo set namespace
  • odo preference *

And these commande not dependent of a devfile.yaml if a name is specified with --name:

  • odo delete component
  • odo describe binding
  • odo describe component

Which issue(s) this PR fixes:

Fixes #6971

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label Sep 1, 2023
@netlify
Copy link

netlify bot commented Sep 1, 2023 •
edited
Loading

✅ Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 840eb12
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/64f5ebd4e6a2510008594534

@openshift-ci openshift-ci bot requested review from kadel and rm3l September 1, 2023 12:03
@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

Windows Tests (OCP) on commit c70826b finished successfully.
View logs: TXT HTML

@feloy feloy removed the request for review from kadel September 1, 2023 12:09
@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

NoCluster Tests on commit c70826b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

OpenShift Unauthenticated Tests on commit c70826b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

Unit Tests on commit c70826b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

Validate Tests on commit c70826b finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the bugfix-6971/odo-registry-invalid-devfile branch from e78da0b to a018240 Compare September 1, 2023 12:28
@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

Kubernetes Tests on commit c70826b finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

OpenShift Tests on commit c70826b finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented Sep 1, 2023 •
edited
Loading

Kubernetes Docs Tests on commit 03c109a finished successfully.
View logs: TXT HTML

@feloy feloy force-pushed the bugfix-6971/odo-registry-invalid-devfile branch from a018240 to 57d44b5 Compare September 4, 2023 07:46
@feloy feloy requested a review from rm3l September 4, 2023 08:12
rm3l
rm3l reviewed Sep 4, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, how about enriching the existing test cases for the commands that do not need a valid devfile? Could be helpful in the future, I think..

pkg/odo/genericclioptions/runnable.go Show resolved Hide resolved
@feloy feloy force-pushed the bugfix-6971/odo-registry-invalid-devfile branch from 57d44b5 to 840eb12 Compare September 4, 2023 14:38
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 4, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.0% 7.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@feloy feloy requested a review from rm3l September 4, 2023 14:47
rm3l
rm3l approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@rm3l rm3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Sep 4, 2023
@feloy
Copy link
Contributor Author

feloy commented Sep 4, 2023

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [125.559 seconds]
E2E Test starting with non-empty Directory test debugging [It] should verify developer workflow from non-empty Directory
/go/odo_1/tests/e2escenarios/e2e_test.go:329

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2023

@feloy: Overrode contexts on behalf of feloy: OpenShift-Integration-tests/OpenShift-Integration-tests

In response to this:

/override OpenShift-Integration-tests/OpenShift-Integration-tests

[FAILED] [125.559 seconds]
E2E Test starting with non-empty Directory test debugging [It] should verify developer workflow from non-empty Directory
/go/odo_1/tests/e2escenarios/e2e_test.go:329

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Sep 4, 2023

/override "SonarCloud Code Analysis"

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2023

@feloy: Overrode contexts on behalf of feloy: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@feloy
Copy link
Contributor Author

feloy commented Sep 4, 2023

/override "SonarCloud Code Analysis"

@openshift-ci
Copy link

openshift-ci bot commented Sep 4, 2023

@feloy: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • SonarCloud Code Analysis

Only the following failed contexts/checkruns were expected:

  • Kubernetes-Integration-Tests/Kubernetes-Integration-Tests
  • OpenShift-Integration-tests/OpenShift-Integration-tests
  • Unit-Tests/Unit-Tests
  • ci/prow/odo-ocp4.13-lp-interop-images
  • ci/prow/odo-ocp4.14-lp-interop-images
  • ci/prow/v4.10-images
  • ci/prow/v4.11-images
  • ci/prow/v4.12-images
  • ci/prow/v4.13-images
  • netlify/odo-docusaurus-preview/deploy-preview
  • pull-ci-redhat-developer-odo-main-odo-ocp4.13-lp-interop-images
  • pull-ci-redhat-developer-odo-main-odo-ocp4.14-lp-interop-images
  • pull-ci-redhat-developer-odo-main-v4.10-images
  • pull-ci-redhat-developer-odo-main-v4.11-images
  • pull-ci-redhat-developer-odo-main-v4.12-images
  • pull-ci-redhat-developer-odo-main-v4.13-images
  • tide
  • validator/Validate

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a658121 into redhat-developer:main Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rm3l rm3l rm3l approved these changes

Assignees

@rm3l rm3l

Labels
kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running odo registry from a directory containing invalid devfile errors out
3 participants
@feloy @rm3l @openshift-merge-robot